-
Notifications
You must be signed in to change notification settings - Fork 296
wip test of gha #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
wip test of gha #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not set for non GPS activities when swiching sctivities A few cleanups
only started after a pause. * each step was started multiple times * validateSeconds did not handle not parsable data
Incorrect error handling reported in Play Console
EdgeToEdge is implemented previously, this enables a Play Console suggestion.
Mostly using Gemini, some manual fixes and updates to comments etc.
For markers, use popup instead of displaying on map. In addition to time/instace, include current pace/elevation/hr.
Followup to previous AsyncTask migration. Partly using Gemini, but manual fixes required.
Many no longer needed with minsdk >= 21
no longer needed since sdk 21 > 17 right/left attributes can be removed
All automated changes. Primarily use of Java records.
Cherry picked warnings that seem relevant
to avoid deprecated Gradle usage remove the variants for specific hardware. This was not used by Play or F-droid, only private builds.
Especially for extensions
Use the (beta) androidx libraries to adjust the WGS84 elipsoid to EGM2008 se level elevation. The functionality is built in to Android 14 and later and available in androidx libraries (that may require that the libs are downloaded). The previous implementation used a custom EGM96 model bundled with the app.
d363b41 to
722f1f2
Compare
Collaborator
Author
|
superseded by #1307 (some other PRs will be created too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.